Open GuardianMajor opened 7 years ago
Thanks for reporting with comprehensive details. I haven't yet gone through the backlog of issues and consolidated them into concrete tasks to implement, so I'll leave this open for now.
@Eloston , you are very welcome and thank you for creating this and maintaining it. I finally got annoyed enough by it to begin drafting a way to do it myself when I saw yours and I was like, duh - why reinvent the wheel, an amazing job already done, just contribute to it and help. SO I am here for you if you need it, just hit me up and let me know where I can lend a hand.
I am open to some development on the 0.6 series (on the 0.6-maintenance
branch) if there are small chnages you wish to make. If you wish to make larger changes, I am also open to help on the rewrite for version 0.7. (Head over to #114 for more details).
@Eloston, done, give me some time to read through everything, get caught up on the existing incarnation of the code and I'll send over anything I feel would be useful to your rewrite. Thank you.
I just got dragged over to an AOL page which proceeded to annoyingly play the video and nothing was stopped. It could be related to the already reported issue #71 or it might be something different.
I am sure it applies to the whole site (as well as their other sites) but the dumb post that happened for me is here in case you need an actual test case (https://www.aol.com/article/entertainment/2017/01/20/chrissy-teigen-and-john-legend-enjoy-broadway-date-after-shockin/21659364/)
I stripped off the "tracking" crap tagged to the link when it force pushed itself, and didn't include it so they don't get any more credit for it, but in case it might be necessary for your test, here it is by itself
I doubt the parameters will affect the ability to block, but who knows, better to have more information and not need it than not have enough and need it.
Let me know if I can provide anything else. Thanks.