search

Elskom / Els_kom_new

Els_kom for Elsword and Grand Chase KOM Files.
MIT License
29 stars 16 forks source link

Dependency version warnings most likely resulting in build error #180

Open Khidezeeh opened 3 years ago

Khidezeeh commented 3 years ago

Describe the bug By following the guides on how to build both Els_kom_new as well as Elskom.Sdk I encounter an issue where trying to build Els_kom_new (either via Visual Studio 2019/2019 Preview) will result in errors most likely related to the version of dependencies used is below the required ones.

To Reproduce Build Elskom.Sdk as explained on the above mentioned guide and add the directories to NuGet. Proceed then to build Els_kom_new as explained on the above mentioned guide EIther open up the solution via Visual Studio or run the command Notice the warnings:

SettingsFile 2.0.0 depends on System.Text.Json (>= 6.0.0-preview.3.21162.11) but System.Text.Json 6.0.0-preview.3.21162.11 was not found. An approximate best match of System.Text.Json 6.0.0-preview.3.21163.4 was resolved.   Els_kom
Microsoft.Extensions.DependencyInjection (>= 6.0.0-preview.3.21162.11) but Microsoft.Extensions.DependencyInjection 6.0.0-preview.3.21162.11 was not found. An approximate best match of Microsoft.Extensions.DependencyInjection 6.0.0-preview.3.21163.4 was resolved.

Notice the errors:

`string[]' does not contain a definition for 'Source' and no accessible extension method 'Source' accepting a first argument of type 'string[]' could be found (are you missing a using directive or an assembly reference?)    Els_kom (net472), Els_kom (net5.0-windows)

Most likely due to this, this error will pop up which leads to the build to fail. It might be worth mentioning that I was unable to find the versions required, even when looking into future versions of such dependencies.

Expected behavior The solution is sucessfully built.

Screenshots Screenshot 2021-03-14 093937 Screenshot 2021-03-14 093954

AraHaan commented 3 years ago

Wait what?, the Sdk should have been the only place to being in both of those packages, and then the program should use whatever version the compiled binaries used.

Also I changed some things in SettingsFile as I have had bugs with the plugins source urls randomly getting wiped out for some reason on the json settings file.

AraHaan commented 3 years ago

The build errors was infact from my changes to the SettingsFile project in the Sdk. And that was due to the fact that it had bugs where the source urls would somehow get wiped from the json file every time it goes to try to load/save them.

AraHaan commented 2 years ago

I currently fixed the build errors locally by making the runtime into a .NET Workload which should make it easier to build the program as well.