EltonChou / TwitterMediaHarvest

Download twitter media with only one-click.
https://chrome.google.com/webstore/detail/media-harvest-twitter-med/hpcgabhdlnapolkkjpejieegfpehfdok
MIT License
382 stars 33 forks source link

[FEATURE]: Drag and drop parts of filename pattern #116

Closed Laurens256 closed 8 months ago

Laurens256 commented 8 months ago

Is your feature request related to a problem? Please describe. Currently, the way to set the filename pattern order is by clicking the boxes in the order you want. This works, but it might be more intuitive if you could drag and drop the boxes to order them.

Describe the solution you'd like Here's a very quick and dirty sketch of what I mean (don't pay attention to the styling): image Above you'd still have the options and you can click them to add or remove them from the list below. Then in the list below, you can drag and drop to reorder the pattern

Describe alternatives you've considered Some variation of this idea where you drag items from the top list instead of clicking, but I think the idea described above is better personally

If you want I could create a pr for this using something like SortableJs. If this is not something you want added, feel free to close the issue :)

EltonChou commented 8 months ago

I like this idea, feel free to open the pr. You can start from this part. https://github.com/EltonChou/TwitterMediaHarvest/blob/c08f02609c1265ad27748de8694c416953ff74e1/src/pages/components/GeneralOptions.tsx#L12-L50

At first, I want to implement this feature, but i'm not familiar with drag-drop api and this component was set only once in most of the time.

Laurens256 commented 8 months ago

Alright, not sure when I'll have time to research / implement this but I will keep you updated