EltonChou / TwitterMediaHarvest

Download twitter media with only one-click.
https://chrome.google.com/webstore/detail/media-harvest-twitter-med/hpcgabhdlnapolkkjpejieegfpehfdok
MIT License
427 stars 36 forks source link

[BUG] Audio missing, video seemingly corrupt #123

Closed iilme closed 10 months ago

iilme commented 10 months ago

Describe the bug Any video uploaded after November 30th corrupts the audio, causing VLC to play the first 2 seconds and loop (no audio), and QuickTime to completely refuse to open the video (unknown error -12842)

To Reproduce Steps to reproduce the behavior:

  1. Download anything uploaded December 1st, December 2nd, etc.
  2. Open file
  3. See error.

Expected behavior Video is expected to have audio, and not crash QuickTime.

Screenshots

obraz

Desktop (please complete the following information):

Additional context Could potentially be a changed encoding on Twitter's part, would be a good idea to check for codec changes in files to potentially reencode on-the-fly

EltonChou commented 10 months ago

Can't reproduce the issue. This extension is a downloaderm. It was not a video encoder or decoder, it only triggers browser's download api. I noticed you use firefox nightly build, you should try it in stable build.

iilme commented 10 months ago

I can't really install it in Stable. No matter what I uncheck in the config, what I do in the settings, it refuses to install because it's unsigned.

EltonChou commented 10 months ago

You can download the signed xpi in release page.

iilme commented 10 months ago

Tried it on 122.0 Stable, same problem.

Some tweets that definitely give me this issue: https://x.com/Focke_3/status/1730948457073176996?s=20 https://x.com/gaydrainerboy/status/1730607923833770016?s=20 https://x.com/ItsameWario48/status/1730334678500933952?s=20 https://x.com/DavidBHayter/status/1730741921172091097?s=20

Anything older than November 30th, works fine.

iilme commented 10 months ago

I decided to try it on 122.0 Stable on Fedora Linux 38, x86-64; works perfectly fine. I have no idea if it's a Firefox on Mac thing or a MacOS / Apple Silicon thing, but it is definitely weird.

Apologies for opening a ticket if it is a hardware problem.

EltonChou commented 10 months ago

You can try some chromium based browsers or other video players like VLC. Feel free to reopen this if you have any problem in stable environment.

pavelric commented 10 months ago

Hi,

Posting in this issue since I'm facing it as well ; tested on Mozilla 120.0 & Mozilla 120.0.1, Windows 10 22H2. Was on 4.2.0 when I noticed this (downloaded from the Mozilla Store around September I believe). Upgraded to 4.2.3 (though xpi file), but issue is still happening.

Videos posted on Twitter before 30th November work fine and have the audio as well (redownloaded them all today to test):

After Dec. 1st though, the videos are sometimes not fully viewable in VLC (corrupted?), nor do they have sound (always the case):

EltonChou commented 9 months ago

Cannot reproduce the error, this extension didn't do any codec processing.