EltonChou / TwitterMediaHarvest

Download twitter media with only one-click.
https://chrome.google.com/webstore/detail/media-harvest-twitter-med/hpcgabhdlnapolkkjpejieegfpehfdok
MIT License
426 stars 36 forks source link

[BUG] download button suddenly doesn't show up #146

Closed MinamikoAAAA closed 4 months ago

MinamikoAAAA commented 4 months ago

The download button suddenly doesn't show up. The shortcut "D" also doesn't work.

Chrome 124.0.6367.158

There's probably a way to reset the add-on, I could use a quick guide ...

MinamikoAAAA commented 4 months ago

Tried: clear cookies, log out from twitter, then log in re-install twitter media harvester add-on couldn't solve the issue

Starayo commented 4 months ago

Also having this issue on a fresh install, was trying after the change today that forces twitter.com links to x.com now broke the scripts I was using previously.

Shortcuts J/K to select tweets work, but no download button and D doesn't do anything.

EltonChou commented 4 months ago

Also having this issue on a fresh install, was trying after the change today that forces twitter.com links to x.com now broke the scripts I was using previously.

Shortcuts J/K to select tweets work, but no download button and D doesn't do anything.

After install, you need to refresh the page.

EltonChou commented 4 months ago

The download button suddenly doesn't show up. The shortcut "D" also doesn't work.

Chrome 124.0.6367.158

There's probably a way to reset the add-on, I could use a quick guide ...

Have you installed any extension which may change twitter's layout?

Starayo commented 4 months ago

Also having this issue on a fresh install, was trying after the change today that forces twitter.com links to x.com now broke the scripts I was using previously. Shortcuts J/K to select tweets work, but no download button and D doesn't do anything.

After install, you need to refresh the page.

I have done that, no change.

I have also tested on a new profile to prevent any other addons or scripts interfering with it. Fresh profile with nothing but media harvest installed, same problem. No button, J/K works, D does nothing. Extension doesn't seem to be having any visible effect as J/K works with it disabled, I see now it's a default twitter keyboard shortcut.

EltonChou commented 4 months ago

Maybe twtiter has pushed some updates to your client. The extension works well in my environment. Is there any error message showed in the console or extension?

birtchh commented 4 months ago

Maybe twtiter has pushed some updates to your client. The extension works well in my environment. Is there any error message showed in the console or extension?

I tried turning off all my extensions that affected twitter, including control panel for twitter and ublock, this is the error message in the console

ESygqn1PLD

and the log x.com-1715828002243.log

The download button is no longer there, this seemed to only start when twitter keeps being redirected to x.com, this seemed to affect all posts, on the timeline and on the post page too. (sry if i missed anything im new at this Y_Y)

Starayo commented 4 months ago

Maybe twtiter has pushed some updates to your client. The extension works well in my environment. Is there any error message showed in the console or extension?

Mine's the same as above, nothing in console except the third-party cookie warnings. No error in the extension that I can find.

With the timing, it probably does have something to do with when they started forcing redirection to x.com for my region (Australia) recently. Previously I was still accessing it via twitter.com.

yuuma0 commented 4 months ago

Maybe twtiter has pushed some updates to your client. The extension works well in my environment. Is there any error message showed in the console or extension?

Mine's the same as above, nothing in console except the third-party cookie warnings. No error in the extension that I can find.

With the timing, it probably does have something to do with when they started forcing redirection to x.com for my region (Australia) recently. Previously I was still accessing it via twitter.com.

A temporary solution you could do is use a VPN while accessing via twitter.com, can confirm that it still works. I think it is a gradual rollout for the force redirection and australia being one of the first ones to get redirected.

I also assume that the API on x.com is different from twitter.com which might be causing it to disappear?

edit: you don't have to keep the VPN on at all times, I think you can go without it after the website loads bypassing the forced redirect

komoreshi commented 4 months ago

A temporary solution you could do is use a VPN while accessing via twitter.com, can confirm that it still works. I think it is a gradual rollout for the force redirection and australia being one of the first ones to get redirected.

I also assume that the API on x.com is different from twitter.com which might be causing it to disappear?

edit: you don't have to keep the VPN on at all times, I think you can go without it after the website loads bypassing the forced redirect

As long as the page isn't refreshed after disconnecting, it works fine. Given the new domain will eventually be rolled out to everyone, it'll still warrant a fix at some stage.

EltonChou commented 4 months ago

As long as the page isn't refreshed after disconnecting, it works fine. Given the new domain will eventually be rolled out to everyone, it'll still warrant a fix at some stage.

I need to find a way to simulate the behavior. Is there any reliable public Australia VPN service? In my environment, the x.com would be directed to twitter.com and it works fine.

EltonChou commented 4 months ago

Root cause https://github.com/EltonChou/TwitterMediaHarvest/blob/4976253a70096f6417e2279b093fe399c16ea570/src/content_script/utils/checker.ts#L20

I will push update soon. Thanks for providing information.

EltonChou commented 4 months ago

v4.2.5

It will take few days to pass the store verification.

Dark-Decay commented 4 months ago

It will take few days to pass the store verification.

Is this why there isn't an .xpi for the Firefox release of v4.2.5 yet? I'm not familiar with how the process works.

EltonChou commented 4 months ago

Is this why there isn't an .xpi for the Firefox release of v4.2.5 yet? I'm not familiar with how the process works.

I have uploaded it. Check release page.