search

EltonChou / TwitterMediaHarvest

Download twitter media with only one-click.
https://chrome.google.com/webstore/detail/media-harvest-twitter-med/hpcgabhdlnapolkkjpejieegfpehfdok
MIT License
455 stars 36 forks source link

[BUG] Extension Crashes Brave Broswer #193

Closed JFDW01 closed 2 months ago

JFDW01 commented 2 months ago

Since earlier today whenever I click the download button it crashes Brave Browser. The file appears to download but then just shuts the browser down.

Going to the Downloads folder there's a .TMP file but no image file. I've tried downloading manually through other websites and they are working normally. This suggests it's isolated to this extension and that it is trying to download but is having an issue for some reason.

I've tried clearing the folder and deleting TMP files. Tweaking settings in the browser (ask location, removing Brave shields, etc) doesn't appear to change anything. Same goes for changing settings in the extension.

I've tried getting rid of extensions that may be interfering. Also tried this same extension on Google Chrome but over there it works normally. Even tried rebooting the computer (as the browser was behaving oddly for a little while).

I've tried uninstalling Brave and installing clean and the same issue happens.

If you can try this same thing in Brave and see if the same issue comes up. Go to a tweet, click the download button, and see if the issue repeats for you with the browser crashing and closing.

Desktop (please complete the following information):

EltonChou commented 2 months ago

I think they might break something in the latest version. If the extension can work properly in older version then it should work in latest version when there is no breaking change on web extension api.

I will take a look if there might be some potential bugs.

EltonChou commented 2 months ago

These might be related issues.

EltonChou commented 2 months ago

This issue was caused by brave. It crashes when extension calls chrome.downloads.download(). This problem can't be solved on this side.

https://github.com/brave/brave-browser/issues/41179

JFDW01 commented 2 months ago

Sounds good. I'll look more into it on my end to see if any solution comes up. I wonder if it may be a good idea to note on the extension page that issues with Brave can occur until a resolution is found.

EltonChou commented 2 months ago

Sounds good. I'll look more into it on my end to see if any solution comes up. I wonder if it may be a good idea to note on the extension page that issues with Brave can occur until a resolution is found.

This is best practice. But every edit on store needs to get reviewed and it takes some times (1~7 days). Once you send the request you can't update extension in this period. If you really need to fix something, you have to cancel the request and it take times too.

JFDW01 commented 2 months ago

Sounds good. I will keep looking for resolutions with Brave and update with findings as they come.

Thank you for your help.

iefremov commented 2 months ago

Fixed in https://github.com/brave/brave-browser/issues/41179

EltonChou commented 2 months ago

@iefremov Thanks for your fix!

JFDW01 commented 2 months ago

Confirmed. Extension is working properly with the fix in above link. Also thank you @iefremov for the fix and @EltonChou for your help.