EltonChou / TwitterMediaHarvest

Download twitter media with only one-click.
https://chrome.google.com/webstore/detail/media-harvest-twitter-med/hpcgabhdlnapolkkjpejieegfpehfdok
MIT License
382 stars 33 forks source link

[BUG] Unable to download video from Card #85

Open fireattack opened 1 year ago

fireattack commented 1 year ago

Describe the bug Unable to download video inside a Card.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://twitter.com/DMMTV_ANIME_PR/status/1679687160398479362
  2. Click on download button

Expected behavior Download the vid

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

EltonChou commented 1 year ago

Thanks for your report.

Card tweet parsing would be enhanced in the future version. That would be helpful if you can provide more card type tweets which you think it should be downloadable.

fireattack commented 1 year ago

I'd say any media_entities in result.card.legacy.binding_values.value.string_value, such as from https://twitter.com/Amamiyastaff/status/1673964451979202560

A slightly tricker case is swipeable media such as https://twitter.com/sacramusic_jp/status/1645713308995952640, where you need to make sure to order the image by slides, since their media entries are sometimes ordered differently (in this particular case, media_1 from slide 1 is using the second media in media_entities, for example).

I believe I've also seen result.card.(legacy.)binding_values.player_stream_url, but I can't find an example right now.