search

EltonChou / TwitterMediaHarvest

Download twitter media with only one-click.
https://chrome.google.com/webstore/detail/media-harvest-twitter-med/hpcgabhdlnapolkkjpejieegfpehfdok
MIT License
382 stars 33 forks source link

[BUG] Downloads fail outside of logged-in container (Firefox Containers) #99

Closed offsetcyan closed 8 months ago

offsetcyan commented 10 months ago

Describe the bug If the extension is run from an account logged in via a Firefox container (official Mozilla extension) Media Harvest tries to download the media from outside of the container context. If the "no container" account isn't logged in, Media Harvest will fail as Twitter's API will reject the request.

To Reproduce Steps to reproduce the behavior:

  1. Create a container and log in to twitter inside that container
  2. Make sure "no container" context is not logged in to Twitter
  3. Inside that container, try to activate the extension on some Twitter media

Expected behavior Media is downloaded as expected.

Desktop (please complete the following information):

EltonChou commented 10 months ago

The addon backend was only loaded in the default container (no container). If you logout twitter in default container, the addon cannot get useful twitter cookie from backend. This can be fixed but the whole workflow need to be redesigned. Since this issue was caused by other extension, I will not do the patch in the near future.

EltonChou commented 8 months ago

Firefox suuport was discarded.

offsetcyan commented 8 months ago

LOL, why?

EltonChou commented 8 months ago

You can check #112 . The firefox version would be only maintained for basic usage.