search

ElucidataInc / ElMaven

LC-MS data processing tool for large-scale metabolomics experiments.
https://resources.elucidata.io/elmaven/
GNU General Public License v2.0
87 stars 52 forks source link

Peak Creation in Peak Editor not saved after applying edits #1356

Open kfoppe opened 3 years ago

kfoppe commented 3 years ago

When editing peak groups in the 'Peak Editor' window, after hitting 'c' to create a peak, the peak is shown to be integrated but upon pressing 'Apply edits' and closing out of the peak editor, the created peaks are not saved to the bookmark table. When I re-open the Peak editor again, the peaks are not saved and the pane reads 'press 'c' to create a peak in this region.

  1. Go to Peak Editorin the Bookmark Table.
  2. Click on 'c' to create a peak
  3. See that the peak area still reads zero instead of the new peak area.

I would expect to see the peak area updated to show that the peak has been created and the peak area is integrated.

kfoppe commented 3 years ago

snip

saifulbkhan commented 3 years ago

@kfoppe This turned out to be happening because of peak quality being set incorrectly for edited peaks. They were getting quality of < 0.1 which was the threshold you had set for global peak quality ("Settings" -> "Peak filtering" -> "Minimum peak quality"). I have fixed this in a separate build which I will share with you shortly over email.