search

ElucidataInc / ElMaven

LC-MS data processing tool for large-scale metabolomics experiments.
https://resources.elucidata.io/elmaven/
GNU General Public License v2.0
87 stars 52 forks source link

[FIX] fixed the crashing of app when ms2 files are loaded and peak detected #1379

Closed ghost closed 3 years ago

ghost commented 3 years ago

We were accessing the isParent function of an adduct even when adduct is not created so it was giving the segmentation fault. Solution was to check if the group is adduct then call the function.

saif-el commented 3 years ago

@MdAzmatAli Thanks for working on this. But I think there was miscommunication from my end and I forgot to update here. This same bug was fixed in another PR that was merged recently. You can see this commit which does nearly the exact same thing as you did here.

I will go ahead and close this PR.