search

ElucidataInc / ElMaven

LC-MS data processing tool for large-scale metabolomics experiments.
https://resources.elucidata.io/elmaven/
GNU General Public License v2.0
87 stars 52 forks source link

After deleting a peak, El Maven quits unexpectedly #1398

Open kehj215 opened 3 years ago

kehj215 commented 3 years ago

Describe the bug For some compounds, when I delete a peak in peak editor, El Maven quits/closes unexpectedly.

To Reproduce Steps to reproduce the behavior:

  1. Select a bookmarked compound
  2. Click on peak editor
  3. double click, select "delete current peak"
  4. El Maven application quits/closes unexpectedly before applying edits or saving

Expected behavior El Maven application does not quit/close unexpectedly.

Screenshots No screenshots included.

System (please complete the following information):

Additional context none

saif-el commented 3 years ago

@kehj215 I tried reproducing this using the two samples you had shared earlier, but could not get it to crash. Do you remember the m/z & rt of the peaks for which you are getting the issue?

kehj215 commented 3 years ago

The m/z that is most problematic is 302.130/284.125 (CE: 16.67) RT 3.10. This one crashes the program nearly every time I delete a peak, but this issue is cropping up for multiple compounds.

saif-el commented 3 years ago

This is the chromatogram I see for that transition:

Screenshot 2021-04-12 at 9 08 32 AM

I do not see a peak at 3.10 minutes. The other two peaks (left and right) are not crashing the software for me. Could it be for one of the other samples that I do not have?

kehj215 commented 3 years ago

Possibly. I also noticed that I can avoid crashing the software if I select multiple samples at once to delete peaks. The software only crashes if I choose a peak one sample at a time to delete.