ElucidataInc / ElMaven

LC-MS data processing tool for large-scale metabolomics experiments.
https://resources.elucidata.io/elmaven/
GNU General Public License v2.0
87 stars 52 forks source link

misplaced string header causes failure during compilation #1415

Open MetabolomicsAustralia-Bioinformatics opened 2 years ago

MetabolomicsAustralia-Bioinformatics commented 2 years ago

When compiling from the source code within the Linux Ubuntu environment by following the guideline on the front page, the fatal error has been triggered.

After a quick code review, the issue (and the solution) has been identified, where the root of the issue is because a string header has been misplaced.

Harry Wang on behalf of Metabolomics Australia (VIC node), University of Melbourne

Error Capture

MetabolomicsAustralia-Bioinformatics commented 2 years ago

The fix is really simple: the string header within the 3rdparty/errorcodes.cpp needs to be moved into the 3rdparty/errorcodes.h

A pull request has been created to fix this issue