search

ElucidataInc / ElMaven

LC-MS data processing tool for large-scale metabolomics experiments.
https://resources.elucidata.io/elmaven/
GNU General Public License v2.0
87 stars 52 forks source link

Clear/reset Memory and parameters #456

Closed Raghavdata closed 6 years ago

Raghavdata commented 6 years ago

As told by Daniel

"One thing I noticed (which is the same as with Maven) is that once you discard all samples, ElMaven suggests to restart. Isn't there a better way? Something like a clear memory button"

Raghavdata commented 6 years ago

@danielbraas In El-MAVEN we have made the parameters more consistent at the code level. This helps in preventing with the inconsistencies which happen when switching between datasets. Having said that there is presently no button to clear memory and set parameters to default.

The team will look into this enhancement and we will get back to you with a solution soon.

sahil21 commented 6 years ago

@danielbraas @Raghavdata The reason why El-MAVEN asks to restart the application because, the memory consumed by El-MAVEN in Linux system is not released completely if you delete samples #36. This has something to do with Linux kernel.

Raghavdata commented 6 years ago

@sahil21 Could we then make the pop up appear only in Linux systems since most of our users are in Windows and this does not affect them.

Raghavdata commented 6 years ago

@sahil21 While at same time I think a set parameters to default might be a good option as well.

danielbraas commented 6 years ago

@sahil21 https://github.com/sahil21 Is the memory "problem" restricted to Linux systems and thus I wouldn't have to restart on a windows PC?

On Tue, Nov 14, 2017 at 2:46 AM, Raghav Sehgal notifications@github.com wrote:

@sahil21 https://github.com/sahil21 While at same time I think a set parameters to default might be a good option as well.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ElucidataInc/ElMaven/issues/456#issuecomment-344219053, or mute the thread https://github.com/notifications/unsubscribe-auth/AT3fMO3fbiHLZycpq3PwceqLRLE3K_w7ks5s2W9ogaJpZM4Qa_aj .

--

Daniel Braas, Ph.D. Adjunct Assistant Professor Scientific Director UCLA Metabolomics Center http://systems.crump.ucla.edu/metabolomics_center/ Department of Molecular and Medical Pharmacology David Geffen School of Medicine at UCLA 4347 CNSI 570 Westwood Plaza Los Angeles, CA 90095-1735 Phone: 310-825-9377 http://systems.crump.ucla.edu/metabolomics_center/

sahil21 commented 6 years ago

@danielbraas Yes, this memory issue problem is only restricted to Linux systems and you don't have to restart El-MAVEN for windows system.