search

ElucidataInc / ElMaven

LC-MS data processing tool for large-scale metabolomics experiments.
https://resources.elucidata.io/elmaven/
GNU General Public License v2.0
88 stars 52 forks source link

Show warning when all peaks are filtered in a group - Peak Filtering options #605

Open sahil21 opened 6 years ago

sahil21 commented 6 years ago

Copying from #549 "Running into a problem with Shift-drag when the peakQuality filter is set to a non-zero value. There are times when I use shift-drag and do not get a group in the bookmark table. (I'm assuming that's because the peakFilter is in play. In such cases, there should be a message to the user maybe?) Once this happens, most peaks that I try to manually integrate, cause the "Same m/z same rt" warning dialog box and the group is not added to the table"

image

chubukov commented 6 years ago

@sahil21 I actually don't understand what's going on here. How is there a group if all peaks are filtered? Doesn't peak filtering happen before grouping?

sahil21 commented 6 years ago

@chubukov

Doesn't peak filtering happen before grouping?

In case of shift-drag integration, this is not the case. An empty group is initialized at first and all the peaks lying in the range of rtmin and rtmax are pushed inside that group.

chubukov commented 6 years ago

@sahil21 Oh I see. So you could reproduce this by shift-dragging across an empty eic.

chubukov commented 6 years ago

@sahil21 implementing #528 would make this moot, right?

sahil21 commented 6 years ago

@chubukov

So you could reproduce this by shift-dragging across an empty EIC.

Yes.

implementing #528 would make this moot, right?

Depends on the implementation but it makes logical sense to combine these two issues.