search

ElunaLuaEngine / Eluna

Eluna Lua Engine © for WoW Emulators
https://elunaluaengine.github.io
GNU General Public License v3.0
377 stars 362 forks source link

Elunaengine not loading scripts when compiled #443

Closed stefan4444333 closed 1 year ago

stefan4444333 commented 1 year ago

Hello, as of yesterday's date, when i was trying to compile a fresh ElunaTrinityWoltk server, i have an issue. I follow every step from the trinity installation guide and with every other core it works, but when i try to compile elunatrinitycore i stumble on a problem, to be more exact this: image In the LuaEngine.cpp. As i have read the code it is just some checks to see if the file is hidden, so i deleted it and the compilation worked and everything was built. But when i start my server i get this image Which is odd but i haven't thought anything about it, but the problem is when i try to load lua scripts, it doesn't load or show they have been loaded since i have added some checks on most of my scripts to be sure that they have all loaded . Can this be an issue from my side or is this an issue with elunaengine for trinitycore?

Rochet2 commented 1 year ago

The compilation error should now be fixed.

However, the issue with scripts and prints not working needs to be looked at. TC made a few refactorings and changes recently that may have broken something on our side.

Seems that in addition to ELUNA_LOG* macros, we need to take a look if we use PQuery, PExecute, PAppend or similar database methods.

stefan4444333 commented 1 year ago

I think they said to me what the problem was, instead of using %u, they use {} to print, or thats what i think it is, hope its helpful.

Foereaper commented 1 year ago

https://github.com/ElunaLuaEngine/ElunaTrinityWotlk/commit/aaa6e73c8ca6d60e943cb964605536eb78219db2

Commit that changed how strings are formatted. We either need to change the macro or we need to ifdef the outputs in Eluna

Rochet2 commented 1 year ago

Fixed in:

Thanks for reporting.