search

Elv13 / awesome-configs

My AwesomeWM configuration
126 stars 19 forks source link

Fixed volume widget visualization and control #12

Closed AxelTB closed 9 years ago

AxelTB commented 9 years ago

Fix part of #11 Does not fix + and - channel button

Elv13 commented 9 years ago

Hello,

Thanks a lot for your patch. Very few people dared to attack my config code before. Those who did were awesomely rewarded. The code you changed to "fix" the sound module is the oldest of my config (it date back to 2008) and have been broken for years. Your patch does indeed fix the bars themselves. However, it also invert the scroll direction, this is somewhat unwanted. Can you please fix this? I don't mind if you add a second patch to fix the first one (rather than creating a new pull request).

Thanks for the patch (and thanks to actually making a pull request rather than a plain fork like everybody else before you)

AxelTB commented 9 years ago

Hello, you're welcome. Your configuration is by far the most complete I've ever found so attacking your code was the only logical thing to do.

The bug you are talking about seem to occur if the "Natural scrolling" is enabled on the touch pad (Scroll up to go down). If you confirm this I'll add a little script to check if that configuration is enabled and invert the value change.

Elv13 commented 9 years ago

Actually, I think it has to do that the percentage calculation is inverted. 0% (visually) == 100% (volume). I really have no idea why it does that. Maybe it has something to do with the -f6 vs. -f7. I tested this on Ubuntu (at work), I will test on Gentoo later today when I get back home.

As for the config, I will try to clean it a little. It is more a test bed for my modules than a config for end users. Most of the rc.lua is actually tests for various LGI functions. Some features event require Awesome patches like the urgent tags or the new layout widget (ctrl+alt+left/right). Some can cope with that, see: http://i.imgur.com/QBvrn59.png

If you have ideas or patches, I am totally open to see that!

(BTW, my last commit broke the application menu, the next one will fix it)

AxelTB commented 9 years ago

I don't have that issue, the percentage indicated is the right one.

The new version uses (Mostly) pactl instead of amixer since on both Ubuntu and Debian use pulseaudio. Let me know if it works for you.

Tank you for being so helpful