search

Elv13 / awesome-configs

My AwesomeWM configuration
126 stars 19 forks source link

Fix the alt+tab widget #5

Open Elv13 opened 10 years ago

Elv13 commented 10 years ago

The selected tag is wrong

rosshadden commented 10 years ago

This is probably what you're referring to, but just in case it's not:

alttab.altTab() gives me this empty list no matter where or when I run it.

I also get this error when using alttab.altTab({ auto_release = true }).

Elv13 commented 10 years ago

Hello, what is your Awesome version, are you using the lastest awesome-configs? And yes, this is not related to this bug, I should have been more explicit. As of a0e04ed1aaa9fdc50b107478bbf5c82c50ebf4d2 , the last+tab works for me. The latest commit might not be the most stable one ever.

The original bug was intended to remind me that if a client is on multiple tags at once, then alt+tab might go "back" to the wrong tag. This is hard to fix given how Awesome store this.

rosshadden commented 10 years ago

I'm using awesome v3.5.5. I'm not using any part of your awesome-configs repo except the aforementioned lines (and the require of the alt-tab module of course), which is possibly the problem.

Elv13 commented 10 years ago

Yea, I havn't tried in a while. I added a tight coupling with the taglist, tasklist and alt+tab module that probably broke the alt+tab module

Elv13 commented 10 years ago

That bug would belong to Radical, you need to add the whole radical module to have at least a chance of making it work, but that probably wont be enough anymore

rosshadden commented 10 years ago

Yeah unfortunately I'm requiring both radical and radical.impl.alttab. If I find time I will include more things and see if I can narrow it down, and then if necessary I'll make a new issue. Thanks!

Elv13 commented 10 years ago

The easy way is to install Xephyr and open it

Xephir :1 -screen 800x800

and

DISPLAY=:1 awesome

Open some apps and trigger the alt tab, some errors should show up. Also, are you sure you did add the keybindings to your rc.lua?

Elv13 commented 10 years ago

Ok fixed https://github.com/Elv13/radical/commit/9a78433e1edda8283ea10e034dd0487025b056cf

rosshadden commented 10 years ago

That was it, thank you! Now that it works I can see this is such a beautiful widget. Much better than one I threw together using growl notifications.

Elv13 commented 10 years ago

It is quite powerful too, in the non-auto-release mode, you can use shift to add a client to the tab and control to move it to the current tag. It will also highlight the client border to be able to better see the current position.

If you also use the taglist and tasklist modules, then it will integrate with them by highlighting the tags used by the selected alt+tab item to cause less tag switching confusion. The visual style of the tag/tasklist widget is configurable. There is currently 6 styles available, "basic" look like the current AwesomeWM default look.

Used with Tyrannical, some more features get activated.