search

Elv13 / radical

An extensible menu subsystem for Awesome WM
223 stars 16 forks source link

Remove items second dimensions [HIDDEN API BREAK] #11

Closed Elv13 closed 10 years ago

Elv13 commented 10 years ago

the current way radical store items is a 2 dimension array. Nothing use the second dimension, so there is [1] everywhere in the code. The rational for this was that some menu need to be represented in 2D and radical.base is supposed to provide a complete abstraction that handle all use case. However, the grid menu show that having 2 dimension is [limited but] possible with 1 dimension. Adding the second dimension make the code more complicated and this is currently broken anyway. It was a mistake to add it in the first place.

I need to remove (of fix) it so I can implement abstract re-order / reflow support (have a pool of items, without order that can dynamically be added/moved/removed in batch). This is, in turn, necessary to port the tasklist and taglist to radical (yes, this is the hidden goal of most of the last ~30 commits).

This is an early warning, I will do it soon

Elv13 commented 10 years ago

Please report any valid regression.