Closed Animuswow closed 6 years ago
If your using WoD models it's the patch that makes has this bug not ElvUI unfortunately :(
@crumdidlyumshis hmm, i'll download the non WOD models version and give it a shot, thanks mate! :D
NP! :)
Just registered to report on this issue.
I contacted the author of the WoD models on the modcraft.io forum, and he claims there is no issue with 3D portraits using the default blizzard UI. He pointed me to this github to bring the issue up here.
This is an issue with the models. Not the UI. If you disable the Models, it will work fine.
Yes this is a issue with the models and not ElvUI. There is a possible hack that can fix this but it's not necessary as it is the models that produce this bug. I've tested this multiple times in the past with the wod models.
I've reported the issue to the WoD models author, but he seems to believe its not an issue with his models. I'm not sure he's willing to accept its his problem. Maybe a couple of you guys could chime in? http://www.modcraft.io/index.php?topic=10800.270
Of course, its Finsternis. He is super difficult to communicate to and he likes to point the fault elsewhere. I've messaged him about before. All is good according to him. >_>I am not sure what else to do. I will make a post about it too I suppose.
Also, @silentwinter has posted about this before: #280
I tried the patch suggested in that thread, but it completely breaks the unitframes.
Maybe we can release a small addon to patch this until the said guy can accept the problem he has and fix it or people can use a small addon we make to hook into and tweak this for uses. @crumdidlyumshis @Bunny67 @Loaal
@kkthnx that sounds like a good solution until then :)
@Kkthnx what is this addon you speak of?
This has been an issue ever since Fern released his legion pack. And yes, as Crum pointed out, I opened this issue and closed it as I was able to manually fix it by doing this : https://github.com/ElvUI-WotLK/ElvUI/compare/master...silentwinter:patch-1
I've noticed an issue with the code above; you gotta add "then" at the end of line 119.
It should fix all the portrait issues. Only problem is that your character will "bump" into and look really ugly. (if you are undead, that is.)
Perfectly fine for Dwarf female, Human females. A lil issue with Undeads only.
Basically, on ElvUI/modules/unitframes/elements/portrait.lua
On the last function, add this line of code.
Can't seem to insert code properly. Just click on the link above, add "then" at the end of line 119.
Fix added to ElvUI_Enchanced
Perfect! works great, even for Undead. Thanks!
In relation to the last comment posted that it works for undeads, it "works" in the sense it does center the portrait on the head but other than that it is unusable since the zoom just goes straight through the face.
The 3D portrait nameplate for all undead shows only the body instead of the face, while it should show the face only. Have confirmed that i'm using the lastest updated elvui.