ElvUI-WotLK / ElvUI

ElvUI for World of Warcraft - Wrath of the Lich King (3.3.5a)
https://discord.gg/UXSc7nt
431 stars 152 forks source link

Nameplates: Mouseover and Focus - elements not updating #792

Open Zidras opened 3 years ago

Zidras commented 3 years ago

Description

Mouseover Unit: function NP:SetMouseoverFrame(frame) has a few issues:

Still on mouseover issues:

Focus Unit: castbar is not being shown on this unit.

Version Number

6.08

Steps to Reproduce

Explained above.

Expected Behavior

Mouseover and Focus unit should have their elements updated.

Actual Behavior

Explained above.

Only ElvUI Enabled

Yes

Blizzard Issue?

No

Additional Information

No lua errors.

Error Log

Zidras commented 3 years ago

Thanks Bunny for the focus fix: https://github.com/ElvUI-WotLK/ElvUI/commit/71a75d3cf3de2241d549a7a216215e1a3277dda0 and https://github.com/ElvUI-WotLK/ElvUI/commit/a3e24d253f00c1c4be9367b6264e88de922ce275

Mouseover is proving to be more challenging because it doesn't fire any UNIT events when something is mouseovered... only updates elements once on UPDATE_MOUSEOVER_UNIT. Any ideas? Throwing an idea here... it might be ugly and totally inefficient (and therefore not worth it at all to implement) but would some sort of loop checking for UnitGUID("mouseover") at each UPDATE_MOUSEOVER_UNIT to determine if we have a valid mouseover unit and plate and then run the NP update elements functions?