ElvUI-WotLK / ElvUI

ElvUI for World of Warcraft - Wrath of the Lich King (3.3.5a)
https://discord.gg/UXSc7nt
423 stars 150 forks source link

Display issues with TSM since the recent AH Skin update #808

Open eTzmNcbkrng opened 3 years ago

eTzmNcbkrng commented 3 years ago

Description

A number of elements are overlapping at the bottom of the AH Frame when TSM tabs are selected. image

Version Number

eafec2b6

Steps to Reproduce

  1. Update ElvUI to a point where you have commit eafec2b6

Expected Behavior

https://github.com/ElvUI-WotLK/ElvUI/blob/eafec2b6a5a091dfefe80864f7f3561c09217d80/ElvUI/Modules/Skins/Blizzard/AuctionHouse.lua#L103-L114

TopLeft of Tab1 is supposed to be anchored to the BottomLeft of AuctionFrame, when a TSM tab is selected, the AuctionFrame grows slightly and Tab1 should move down accordingly with the rest of the Tabs following suit as they are anchored relative to Tab1.

Actual Behavior

Tab1 is not moving when a TSM tab is selected, it's as though ElvUI is not registering that the AuctionFrame has grown slightly.

Only ElvUI Enabled

Have run /luaerror on and also enabled TSM modules. Here is output of macro I wrote showing all enabled addon: /script for i=1, GetNumAddOns() do local n,_,_,e = GetAddOnInfo(i); if (e==1) then print(n) end end

[11:29:14] TradeSkillMaster
[11:29:14] TradeSkillMaster_Accounting
[11:29:14] TradeSkillMaster_AuctionDB
[11:29:14] TradeSkillMaster_Auctioning
[11:29:14] TradeSkillMaster_Crafting
[11:29:14] TradeSkillMaster_Destroying
[11:29:14] TradeSkillMaster_ItemTracker
[11:29:14] TradeSkillMaster_Shopping
[11:29:14] ElvUI
[11:29:14] ElvUI_OptionsUI

Blizzard Issue?

Specifically an addon issue.

Additional Information

TradeSkillMaster version in use is here: https://github.com/Wrath-AddOns/TradeSkillMasterPlus

Also when first logging in or /reloading, the TSM tabs are unclickable until one of the Default Blizzard tabs is clicked first, this is also new since the skin update.

Error Log

No Errors

eTzmNcbkrng commented 3 years ago

I've fixed the issue with this commit https://github.com/eTzmNcbkrng/ElvUI/commit/ad0b7706e8fdebc81ce9f9563e34d77c0bb6c881

Endrju1992 commented 10 months ago

I've fixed the issue with this commit eTzmNcbkrng@ad0b770

Hi, I pasted your code from this ElvUI/Modules/Skins/Blizzard/AuctionHouse.lua file into mine and seems it fixed that issue. Idk why since 2 years nobody test/accept this commit. image

eTzmNcbkrng commented 9 months ago

@Endrju1992 I stopped playing PServers a few years ago but all of my PRs from that time are still open, you could have a look at some of the QOL edits I submitted, and some of the ones in my Fork that I didn't submit. I played on ChromieCraft and at the time, the logic for detecting a Tank/DPS was impossible to attain due to the level cap so I changed it to just look at whether you were had active Defensive Stance/Bear Form/Frost Presence/Righteous Fury.