search

ElvUI-WotLK / ElvUI_Enhanced

15 stars 22 forks source link

[Bug] Nameplate chat bubble issues #60

Closed Zidras closed 2 years ago

Zidras commented 5 years ago

[Related to issue #52; Btw, thanks a lot for adding the feature!]

  1. NPC nameplates chatbubbles are not showing

With NP and ENP chatbubbles (actual behaviour): image Without NP (expected behaviour): image

  1. Sender name is sometimes not showing on nameplate chatbubble. Also, it appears something is causing strata difference between image 1 and 3.

Image 1 showing missing name: image

Image 2 is after disabling nameplates, correctly showing sender name: image

Image 3 (with ENP) is correctly showing sender name. image

Zidras commented 5 years ago

@Bunny67 With the https://github.com/ElvUI-WotLK/ElvUI_Enhanced/commit/c292e6be2167d6ff3de7e4e43e82f7101993dd19 still couldn't get the chatbubbles to work on ENEMY_NPC (friendly_npc working fine). Tested in:

(everything else on the report was fixed thank you)

Zidras commented 5 years ago

I also noticed replication of chatbubbles if the source has the same name as other npcs (saw this on Culling of Stratholme with Stratholme Resident chatbubble). Doesn't bother me much since I think it won't happen often (and also since it might be difficult if not impossible to fix) but I thought you should know. FYI, everything else appears to be working. If I find anything else I'll post here thx.

Zidras commented 2 years ago

Closing this issue, since arg12 (guid) returns "", which makes it impossible for any sort of guid matching with cached nameplate guid and thus chatbubble duplication is unavoidable.

image

A potential mitigating resource would be either counting how many plates in NP.VisiblePlates have the same name and only consider the first one, or break the chat bubble loop on the first found, both of which wouldn't be reliable as there would be no guarantee that the first found plate would be the actual plate that spoke.