ElvUI-WotLK / ElvUI_EnhancedFriendsList

4 stars 1 forks source link

Latest Update - 8/18/16 #2

Closed Crumdidlyumshis closed 8 years ago

Crumdidlyumshis commented 8 years ago

https://github.com/ElvUI/ElvUI_FriendsListColor/commit/c92fabf5c9f3ca59f2bc444bdcb0b57fba03de48

world of warcraft 8_18_2016 2_47_37 pm

Shouldn't it be like this?:

Good: Monka, Level 50 Hunter

Bad: Monka,Level 50

Also, aren't the colors of the numbers (1-80) supposed to be colored in relation to your level?

Bunny67 commented 8 years ago

Lua errors included?

Crumdidlyumshis commented 8 years ago

Hmm, ill try again. I didn't see any LUA errors popup.

Crumdidlyumshis commented 8 years ago

Nope, no LUA errors. I have it enabled.

Bunny67 commented 8 years ago

new update removes the color level, is working only on the client ru :(

Crumdidlyumshis commented 8 years ago

Could the plugin have an option in ElvUI to enable color if preferred?

Maybe a Checkbox with yes or no color.

If not, which line could I edit to show the color?

Bunny67 commented 8 years ago

check update

Crumdidlyumshis commented 8 years ago

Haha so close!

world of warcraft 8_18_2016 3_28_39 pm

Almost there!

Bunny67 commented 8 years ago

:(

Bunny67 commented 8 years ago

check

Crumdidlyumshis commented 8 years ago

Ill mess with it and see if I can't help some. Your work is much appreciated Bunny!

Crumdidlyumshis commented 8 years ago

local textFormat = locale == "ruRU" and "%s%s|r, %s%s-го уровня" or locale == "enUS" and "%s%s|r, %sStufe %s" or "%s%s|r, %sLevel $s";

enUS

Bunny67 commented 8 years ago

"%s%s|r, %sLevel $s" = all locale except the ruRU and deDE. not necessarily add enUS Right now it works?

Crumdidlyumshis commented 8 years ago

I think I fixed it... http://pastebin.com/vs0hanuZ

world of warcraft 8_18_2016 7_52_49 pm

Also I get an error when friends sign on and off:

ERROR 1

Message: ...ns\ElvUI_FriendsListColor\ElvUI_FriendsListColor.lua:29: attempt to index local 'friend' (a nil value) Time: 08/18/16 22:14:56 Count: 2 Stack: [C]: ? ...ns\ElvUI_FriendsListColor\ElvUI_FriendsListColor.lua:29: in function <...ns\ElvUI_FriendsListColor\ElvUI_FriendsListColor.lua:24> (tail call): ? [C]: in function `FriendsList_Update' Interface\FrameXML\FriendsFrame.lua:1193: in function <Interface\FrameXML\FriendsFrame.lua:1188> (tail call): ?

Locals:

ERROR 2

Message: ...ns\ElvUI_FriendsListColor\ElvUI_FriendsListColor.lua:29: attempt to index local 'friend' (a nil value) Time: 08/18/16 22:16:57 Count: 1 Stack: [C]: ? ...ns\ElvUI_FriendsListColor\ElvUI_FriendsListColor.lua:29: in function <...ns\ElvUI_FriendsListColor\ElvUI_FriendsListColor.lua:24> (tail call): ? [C]: in function FriendsList_Update' Interface\FrameXML\FriendsFrame.lua:245: in function <Interface\FrameXML\FriendsFrame.lua:243> [C]: in functionShow' Interface\FrameXML\UIParent.lua:1580: in function SetUIPanel' Interface\FrameXML\UIParent.lua:1424: in functionShowUIPanel' Interface\FrameXML\UIParent.lua:1311: in function <Interface\FrameXML\UIParent.lua:1307> [C]: in function SetAttribute' Interface\FrameXML\UIParent.lua:1974: in functionShowUIPanel' Interface\FrameXML\FriendsFrame.lua:1431: in function `ToggleFriendsFrame'

Locals:

Bunny67 commented 8 years ago

Class text does need? After all, the name of the color of the class

Crumdidlyumshis commented 8 years ago

I put some spacing in-between the icon and text and changed the level to #999999 hexadecimal value.

local textFormat =
locale == "ruRU" and "%s%s|r, %s%d-го уровня" or
locale == "deDE" and "%s%s|r, |cffb3b3b3Stufe %s%d" or
"%s%s|r, |cff999999Level %s%d";

textFormat = " " .. classIcon .. " " .. textFormat;

world of warcraft 8_19_2016 11_14_38 am

How can I add the class name after the level?

Bunny67 commented 8 years ago

offline level text is too bright :(

Crumdidlyumshis commented 8 years ago

im gonna close this.