search

ElvenTools / elven-nft-minter-sc

Elven Tools NFT Minter Smart Contract - launching NFTs collections on the MultiversX blockchain
https://www.elven.tools
50 stars 32 forks source link

Remove the gateway entry and leave only the ipfs:// schema based uri #18

Closed juliancwirko closed 2 years ago

juliancwirko commented 2 years ago

For now, in the assets in the explorer, there are two uris for the same image. One with the ipfs:// schema and one with the ipfs.io gateway. I think it is worth removing the gateway entry and leaving only the ipfs://schema-based URI. There are at least three reasons:

  1. There is an Elrond gateway anyway, so everyone can use it or take the cid and use a different gateway.
  2. The Explorer is now supporting previews also for the ipfs:// based uris (on hover)
  3. It is misleading for many people. They see one gateway, and then there is another one after mint. With the ipfs:// based uris, it will be more precise.
  4. It will also be better for the SC because the performance will be better.

Cons:

  1. You won't be able to click on the link in the assets section in the explorer. You would need to use the gateway with the displayed CID.
  2. Again, I don't know what with marketplaces. They shouldn't rely on the assets link as a whole. They should have their logic for that.
juliancwirko commented 2 years ago

Done on the development branch. There were no comments, I decided to remove not the gateway, but the ipfs schema-based URI, It is because there are usually gateway Uris only. It is still possible to add the ipfs schema-based Uri to the metadata JSON file. It will be in sync with the metadata file there

juliancwirko commented 2 years ago

done