search

ElvenTools / elven-nft-minter-sc

Elven Tools NFT Minter Smart Contract - launching NFTs collections on the MultiversX blockchain
https://www.elven.tools
50 stars 32 forks source link

Additional entries in the URIs/Asset section #3

Closed juliancwirko closed 9 months ago

juliancwirko commented 2 years ago

The only assets, for now, are the ipfs schema with the base CID and the image file name, and additionally, there is an ipfs gateway URI with the same CID and image name.

Some marketplaces require additional Assets/URIs entries like metadata JSON or collection JSON files. IMO this isn't a place for them. The metadata file for the image is encoded in the attributes, and it can include all additional URIs inside.

But I could implement it as an option. Should it be implemented? Can someone explain why marketplaces require that?

butavpaul commented 2 years ago

https://youtu.be/nn0j52fP1yk?t=545 As Mihai from Trust.market is talking about here, the collection.json is needed for counting the rarities. I don't think it's mandatory but only makes the count easier. If you don't have one, I think the market will create one on their part.

juliancwirko commented 2 years ago

Hey, thanks for the input.

I see it is probably simpler for the particular marketplace, but I wonder why not read them from the main metadata JSON, which is perhaps parsed there anyway. Like the links to the additional JSON files could be saved there. In the Assets/Uris section, I would see only images, video, music, etc., not JSON files with configuration. It all should be included in the primary metadata, which has its CID encoded in the attributes. But this is just my opinion. I probably don't see the whole picture.

The option to add more uris could be helpful anyway, so I will probably think about that after fixing all bugs.

juliancwirko commented 2 years ago

The simple adjustment, for now, will be to add the corresponding metadata to assets by default with the option not to do that. Then a more general solution would be needed.

juliancwirko commented 2 years ago

The possibility to attach the metadata URI is done on the development branch. For now, there won't be the possibility to add other URIs.

juliancwirko commented 2 years ago

You can now choose to attach the corresponding metadata file to the Assets/Uris. I'll leave this thread for the next steps, allowing you to add more entries there.