search

ElvishArtisan / rivendell

A full-featured radio automation system targeted for use in professional broadcast and media environments
197 stars 63 forks source link

Cannot sucessfully compile release 4.1.1 #924

Closed WMTH closed 7 months ago

WMTH commented 7 months ago

Compilation of release 4.1.1 build fails at:

make[1]: Entering directory '/home/rd/dev/rivendell-4.1.1/cae' CXX driver_hpi.o driver_hpi.cpp: In member function ‘virtual int DriverHpi::inputPortQuantity(int) const’: driver_hpi.cpp:96:10: error: ‘d_sound_card’ was not declared in this scope 96 | return d_sound_card->getCardInputPorts(card); | ^~~~ driver_hpi.cpp: In member function ‘virtual int DriverHpi::outputPortQuantity(int) const’: driver_hpi.cpp:102:10: error: ‘d_sound_card’ was not declared in this scope 102 | return d_sound_card->getCardOutputPorts(card); | ^~~~ make[1]: [Makefile:541: driver_hpi.o] Error 1 make[1]: Leaving directory '/home/rd/dev/rivendell-4.1.1/cae' make: [Makefile:552: all-recursive] Error 1

This is seen when compiling in both the current CentOS7 and Ubuntu Jammy environments.

ElvishArtisan commented 7 months ago

What version of hpklinux are you using?

fpeyraud commented 7 months ago

Confirmed here. I had to enclose the line in #ifdef HPI ... #endif like the other functions

WMTH commented 7 months ago

Version 4.20.39-1

From: Fred Gleason @.> Sent: Tuesday, November 21, 2023 8:31 AM To: ElvishArtisan/rivendell @.> Cc: Gary Horn @.>; Author @.> Subject: Re: [ElvishArtisan/rivendell] Cannot sucessfully compile release 4.1.1 (Issue #924)

What version of hpklinux are you using?

— Reply to this email directly, view it on GitHub https://github.com/ElvishArtisan/rivendell/issues/924#issuecomment-1821035888 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARF5FSHLTMI5IEMG2TE4TYFS3L3AVCNFSM6AAAAAA7UVVKJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRRGAZTKOBYHA . You are receiving this because you authored the thread. https://github.com/notifications/beacon/ACARF5BNFPJ2OOC6CJMZERDYFS3L3A5CNFSM6AAAAAA7UVVKJ2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTMRLGXA.gif Message ID: @. @.> >

ElvishArtisan commented 7 months ago

@fpeyraud Ah, I see. You're building without HPI support. Yup, that's a bug!

ElvishArtisan commented 7 months ago

@WMTH But I don't see how you could be goosing this if you're building with HPI support. What does your Rivendell Configuration Summary say after running './configure'? You should have a line in the 'Configured Audio Drivers' section like: 'AudioScience HPI ... Yes'.

WMTH commented 7 months ago

It reports 'AudioScience HPI ... No'. We don’t have any AudioScience cards installed. Up until this release, this has not posed a problem. I did try adding ‘—disable-hpi’ in the configuration options but that had no impact.

From: Fred Gleason @.> Sent: Tuesday, November 21, 2023 9:25 AM To: ElvishArtisan/rivendell @.> Cc: Gary Horn @.>; Mention @.> Subject: Re: [ElvishArtisan/rivendell] Cannot sucessfully compile release 4.1.1 (Issue #924)

@WMTH https://github.com/WMTH But I don't see how you could be goosing this if you're building with HPI support. What does your Rivendell Configuration Summary say after running './configure'? You should have a line in the 'Configured Audio Drivers' section like: 'AudioScience HPI ... Yes'.

— Reply to this email directly, view it on GitHub https://github.com/ElvishArtisan/rivendell/issues/924#issuecomment-1821139457 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARF5DLQJRSZXWGYYGYTIDYFTBT5AVCNFSM6AAAAAA7UVVKJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRRGEZTSNBVG4 . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ACARF5HZMWWICXM5ERI4OKDYFTBT5A5CNFSM6AAAAAA7UVVKJ2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTMRRRAC.gif Message ID: @. @.> >

ElvishArtisan commented 7 months ago

@WMTH Sounds like you're missing the 'hpklinux-dev' package. Adding that and re-running 'configure' should allow the build to proceed. Or, you could make the changes suggested by @fpeyraud. Or, just wait. I plan to cut a release with this fixed later today.

WMTH commented 7 months ago

I am performing a test build now with the addition of the hpklinux-dev package added.

From: Fred Gleason @.> Sent: Tuesday, November 21, 2023 9:33 AM To: ElvishArtisan/rivendell @.> Cc: Gary Horn @.>; Mention @.> Subject: Re: [ElvishArtisan/rivendell] Cannot sucessfully compile release 4.1.1 (Issue #924)

@WMTH https://github.com/WMTH Sounds like you're missing the 'hpklinux-dev' package. Adding that and re-running 'configure' should allow the build to proceed. Or, you could make the changes suggested by @fpeyraud https://github.com/fpeyraud . Or, just wait. I plan to cut a release with this fixed later today.

— Reply to this email directly, view it on GitHub https://github.com/ElvishArtisan/rivendell/issues/924#issuecomment-1821156545 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARF5BPU45JLJV7A7WAEY3YFTCUHAVCNFSM6AAAAAA7UVVKJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRRGE2TMNJUGU . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ACARF5HFH4CECTSS3OOBCBLYFTCUHA5CNFSM6AAAAAA7UVVKJ2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTMRSSMC.gif Message ID: @. @.> >

ElvishArtisan commented 7 months ago

Fixed in e6f6aaa. Please test!

ElvishArtisan commented 7 months ago

@WMTH

I am performing a test build now with the addition of the hpklinux-dev package added.

Thanks. If you could also test the fix I just committed (with the hpklinux-dev package removed), that'd be great. Then I can push a new release.

WMTH commented 7 months ago

Both builds in progress now.

From: Fred Gleason @.> Sent: Tuesday, November 21, 2023 10:08 AM To: ElvishArtisan/rivendell @.> Cc: Gary Horn @.>; Mention @.> Subject: Re: [ElvishArtisan/rivendell] Cannot sucessfully compile release 4.1.1 (Issue #924)

@WMTH https://github.com/WMTH

I am performing a test build now with the addition of the hpklinux-dev package added.

Thanks. If you could also test the fix I just committed (with the hpklinux-dev package removed), that'd be great. Then I can push a new release.

— Reply to this email directly, view it on GitHub https://github.com/ElvishArtisan/rivendell/issues/924#issuecomment-1821218986 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ACARF5GHTZMAVHXHADD7JXLYFTGWRAVCNFSM6AAAAAA7UVVKJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRRGIYTQOJYGY . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ACARF5GUVM2OFOQO4DHFS6LYFTGWRA5CNFSM6AAAAAA7UVVKJ2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTMRWMKU.gif Message ID: @. @.> >

WMTH commented 7 months ago

Both the build with the https://github.com/ElvishArtisan/rivendell/commit/e6f6aaade008f4fdb52ecae20a07be632fd52702 e6f6aaa commit without the hpklinux-dev package and the original 4.1.1 build with the hpklinux-dev package compiled successfully.

From: Fred Gleason @.> Sent: Tuesday, November 21, 2023 10:08 AM To: ElvishArtisan/rivendell @.> Cc: Gary Horn @.>; Mention @.> Subject: Re: [ElvishArtisan/rivendell] Cannot sucessfully compile release 4.1.1 (Issue #924)

@WMTH https://github.com/WMTH

I am performing a test build now with the addition of the hpklinux-dev package added.

Thanks. If you could also test the fix I just committed (with the hpklinux-dev package removed), that'd be great. Then I can push a new release.

— Reply to this email directly, https://github.com/ElvishArtisan/rivendell/issues/924#issuecomment-1821218986 view it on GitHub, or https://github.com/notifications/unsubscribe-auth/ACARF5GHTZMAVHXHADD7JXLYFTGWRAVCNFSM6AAAAAA7UVVKJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMRRGIYTQOJYGY unsubscribe. You are receiving this because you were mentioned. https://github.com/notifications/beacon/ACARF5GUVM2OFOQO4DHFS6LYFTGWRA5CNFSM6AAAAAA7UVVKJ2WGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTMRWMKU.gif Message ID: < @.> @.>

ElvishArtisan commented 7 months ago

Cool. Thank you!