search

ElvishArtisan / rivendell

A full-featured radio automation system targeted for use in professional broadcast and media environments
197 stars 63 forks source link

4.2.2 Permissions: User can edit cut markers with no production rights #961

Closed vizubeat closed 1 month ago

vizubeat commented 1 month ago

I'm logged in as a user that has no Production Rights selected in RDAdmin, but this user can still add/modify/remove markers on cuts. It cannot delete cuts, but modifying markers could be considered just as destructive. Could the ability to edit markers be removed when 'modify carts' is not selected, and/or a new toggle added to make this optional?

ElvishArtisan commented 1 month ago

Confirmed here.

ElvishArtisan commented 1 month ago

Fixed in 1519123. Please test!

vizubeat commented 1 month ago

Thanks Fred - again I need to build another test setup as the other one is being used for testing, but this looks great. Thanks for everything :-)

ElvishArtisan commented 1 month ago

Remember: hypervisors are your friend! :)

vizubeat commented 1 month ago

I cannot compile from source. Just know that I'm trying to help in testing :-)

Screenshot 2024-05-12 at 18 25 33

...that must be a me thing, but I've read and understand the changes in 1519123 and it looks great - thank you!

dklann commented 1 month ago

Confirmed working as expected (commit 8b0dbf57) with a Rivendell user having no "Production" permissions -- no ability to set markers in cuts.