search

Elyovs / pe

0 stars 0 forks source link

DG Activation bar is not deactivated in the end (always activated) #11

Open Elyovs opened 2 months ago

Elyovs commented 2 months ago

CalculaChroniclesOfTheAlgorithmicKingdom activation bar is not deactivated in the end.

image.png

soc-pe-bot commented 2 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

CalculaChroniclesOfTheAlgorithmicKingdom never return in sequence diagram DG

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

CalculaChroniclesOfTheAlgorithmicKingdom should return, even if method called is a void, thus should have a dashed arrow to the left.

image.png

[original: nus-cs2113-AY2324S2/pe-interim#2047] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Screenshot 2024-04-20 at 6.51.43 PM.png Return arrows are not necessary. Furthermore this diagram just serves to show how a command would be processed. The 'd' bar is to show that another command is passed by the user after the initial 'w' command.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: I believe this is not a duplicate as it is a bug on 2 different things, although the same sequence diagram. Here is a bug about the activation bar, while the other one is about the return arrow.

## :question: Issue response Team chose [`response.Rejected`] - [x] I disagree **Reason for disagreement:** If the activation bar is not deactivated in the diagram, it seems like the method is always executed even when there is an end in the lifeline (instance no longer alive). To show how a command would be processed, it may be better to show 1 command or place the repeated method call inside a loop and deactivate the activation bar in the end. This may be clearer to reader compared to showing a call for "d" command and no continuation of the process after and activation bar stay activated all the way.