search

Elyovs / pe

0 stars 0 forks source link

Class diagram symbol for public and private #14

Open Elyovs opened 2 months ago

Elyovs commented 2 months ago

Instead of circle and square (filled and unfilled), private and public should be represented using "-" and "+"

image.png

nus-pe-script commented 2 months ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Invalid UML notation

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

Invalid UML visibility notations (red squares and green circles. Visibility of attributes should follow the notation + - # ~.

image.png

[original: nus-cs2113-AY2324S2/pe-interim#2337] [original labels: severity.Low type.DocumentationBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** I believe this is in scope. Because notation is different from the standard in CS2113, it caused confusion to reader on what the notation means. For instance, how the filled squared and not filled one is different.