Elytrium / LimboReconnect

Reconnect your players after server restart
GNU General Public License v3.0
37 stars 13 forks source link

when sending failed. should configure the interval instead of trying to send again. #11

Closed FallenCrystal closed 1 year ago

FallenCrystal commented 1 year ago

https://github.com/Elytrium/LimboQueue/issues/3 forgive my stupidity. i have too many windows open and dont pay attention to which plugin

SkyWatcher2019 commented 1 year ago

Can you share the config.yml? Looks like misconfigured kick trigger message

FallenCrystal commented 1 year ago

image no. thats right. when a player is kicked out by viaversion because of a version difference when the server is not fully started. i dont want that to happen. because this will kick the player from Velocity

FallenCrystal commented 1 year ago

but since plugin thinks the server is already started. so try to send the player instantly. then move back to limbo. and so on and so forth. i personally think the only solution is to ping whether the text content is returned in the server's motd. or add a send failure retry interval.

SkyWatcher2019 commented 1 year ago

Try to decrease check-interval to 1000-2000

FallenCrystal commented 1 year ago

image image .

FallenCrystal commented 1 year ago

viaversion kicks out different versions of players when the server is not fully started. this is not a matter of checking the interval. check the motd text. or add an interval of attempts. *motd should only be displayed when the server is fully booted. instead of using pure tcpping to check server status.

SkyWatcher2019 commented 1 year ago

Hmm, looks like server responding to the ping before it fully started. Or Via loads after server started?

SkyWatcher2019 commented 1 year ago

instead of using pure tcpping to check server status.

wdym

FallenCrystal commented 1 year ago

Hmm, looks like server responding to the ping before it fully started. Or Via loads after server started?

any minecraft server open ports on initial startup. instead of waiting for the server to start completely.

FallenCrystal commented 1 year ago

all right. lets get a little bit clear: i used viaversion. but though dont use it. the server will still kick different versions of the client. only when the server is fully started. via will accept different(but support) of the client. motd respond only when the server is fully started. it is better than normal ping.

i tried to add limbo when the player was kick because of a different version. if the client is the same version as the server. the server dont kick. open ports are after libraries are loaded. instead of opening when the server is fully started.

SkyWatcher2019 commented 1 year ago

image i don't think it's tcpping and server responds with it's version before full start. I'll take a look at

FallenCrystal commented 1 year ago

i don't think it's tcpping

things like tcpping. something that is not based on the minecraft protocol. i dont quite articulate it

SkyWatcher2019 commented 1 year ago

motd respond only when the server is fully started.

this.server.ping().get(Config.IMP.PING_TIMEOUT, TimeUnit.MILLISECONDS) -> Component description

FallenCrystal commented 1 year ago

motd respond only when the server is fully started.

this.server.ping().get(Config.IMP.PING_TIMEOUT, TimeUnit.MILLISECONDS) -> Component description all right. my stupidity. 1.8 the server responds to motd anyway. ill find some other way to see how to make it work.

SkyWatcher2019 commented 1 year ago

Can you show join-delay parameter from Via?

FallenCrystal commented 1 year ago

Can you show join-delay parameter from Via?

wdym

FallenCrystal commented 1 year ago

idk what youre looking for. they're all here (most of the stuff is the default cfg. because i think its plug and use. https://pastebin.com/L9Tm4HcC

SkyWatcher2019 commented 1 year ago

nvm, misunderstood hevav, gonna add this parameter to limboreconnect

Akiranya commented 1 year ago

nvm, misunderstood hevav, gonna add this parameter to limboreconnect

thanks for the fix! just wanted to let you know that this also fixed: https://github.com/KaspianDev/AntiPopup/issues/36