Em-Ant / fcc-options-app

Options Inc. web app development
Other
12 stars 7 forks source link

Max route time constraint not being observed #25

Closed andrealonzo closed 8 years ago

andrealonzo commented 8 years ago

If the max route time is 90 minutes, you can have a route of 100 minutes and there will be no errors.

Em-Ant commented 8 years ago

This could be handled displaying a warning when calculating directions, if that route exceeds the max time. I'm afraid that getting directions on every vehicle's consumers update would be really slow.

andrealonzo commented 8 years ago

Yes, I agree that putting a warning in the directions would be the best way to go.

andrealonzo commented 8 years ago

Ok i'm working on this

andrealonzo commented 8 years ago

Fixed with 3f6f38df57c1c9bf8b60d840fecef6cc90e83297 A warning is now displayed right below the Max Passenger Duration if this constraint fails.