search

EmAstro / ESOAsg

A collection of useful packages used to validate data for the ESO archive.
10 stars 2 forks source link

update of fix_sphere #14

Closed jmilou closed 3 years ago

jmilou commented 3 years ago

Hello Ema,

I progressed on the script improvement. I modified some inaccuracies and tried to avoid code duplication between IRDIS and IFS. Could you review it and let me know if you are fine with it?

I need to see now how to get the PHOTZP and FLUXCAL, which is more tricky. The other remaining changes now have to be done upstream in our own pipeline (for instance getting the average ABMAGLIM adding the PROVENANCE files). These 2 information are not contained in the fits files themselves but are produced by some recipes upstream in our pipeline, so we need to propagate this information down up to the final result. I am discussing with my colleagues end of the week to see how we can do that

Best regards Julien

jmilou commented 3 years ago

Dear Ema, I implemented the required changes. Let me know if you see them correctly.

We are left now with some other changes required on our side regarding the sensitivity and the PROVENANCE keyword. Everything does not depend on me, so I need to coordinate a bit with Philippe Delorme working on the IRDIS/IFS pipeline and our IT specialist to propagate the changes retroactively.

Cheers Julien

EmAstro commented 3 years ago

Thanks! changes have been merged.