EmDee / moneymoney-bondora

MoneyMoney extension for Bondora
MIT License
13 stars 6 forks source link

Divide Summary account into 2 accounts: Go&Grow and Wallet #17

Closed MarcoH1986 closed 9 months ago

MarcoH1986 commented 2 years ago

Hi Martin,

i extended your script to separate the "value" of the account into 2 accounts (Go&Grow (invested) and Wallet (not invested). Maybe you take a look.

EmDee commented 2 years ago

@MarcoH1986 Thank you! LGTM from a first glancing. Will try to get to a more detailed review on the weekend.

I think we can clean up some of those debug print messages.

EmDee commented 2 years ago

Didn't get to test this during the weekend. Will hopefully be able to do so in the upcoming days.

EmDee commented 2 years ago

@MarcoH1986 I just had a chance to review the code in more detail and test this.

One thing that is giving me a bit of a headache is the needed migration. The change of the account handling would mean that the users will all have to set up the account in Money Money again.

I don't think there are any workarounds for the migration, do you know of any?