Emacs-D-Mode-Maintainers / Emacs-D-Mode

An Emacs mode for D code.
GNU General Public License v3.0
84 stars 22 forks source link

add d-exceptions compilation error regexp #44

Closed snosov1 closed 9 years ago

snosov1 commented 9 years ago

Hey!

This PR does 3 things:

dmakarov commented 9 years ago

I wrote these comments. I guess I didn't want to enforce on users the modifications to a customizable variable compilation-error-regexp-alist, but if someone wanted to use compilation mode with D, they could add the new symbol to the variable.

snosov1 commented 9 years ago

I see your point. But in my opinion it should be the other way around. The vast majority of users will want it to be there by default and in rare cases this might not be desirable. So the users who don't want it should remove it.

russel commented 9 years ago

Can we come to a consensus on whether this should get committed to the mainline? We seems to have 1 for, 1 against, and 1 sitting on the fence (me :-).

dmakarov commented 9 years ago

Hi Russel,

In my opinion it's ok to commit.

snosov1 commented 9 years ago

:+1: