Closed snosov1 closed 9 years ago
I wrote these comments. I guess I didn't want to enforce on users the modifications to a customizable variable compilation-error-regexp-alist
, but if someone wanted to use compilation mode with D, they could add the new symbol to the variable.
I see your point. But in my opinion it should be the other way around. The vast majority of users will want it to be there by default and in rare cases this might not be desirable. So the users who don't want it should remove it.
Can we come to a consensus on whether this should get committed to the mainline? We seems to have 1 for, 1 against, and 1 sitting on the fence (me :-).
Hi Russel,
In my opinion it's ok to commit.
:+1:
Hey!
This PR does 3 things:
core.exception.AssertError@/tmp/app.d(10): unittest failure
)ldc
and the newd-exceptions
rules tocompilation-error-regexp-alist
instead of suggesting to do so in the comment (does anyone read these comments?)