search

Emagister / zend-form-decorators-bootstrap

Zend_Form decorators for Twitter's Bootstrap UI
http://emagister.github.com/zend-form-decorators-bootstrap
168 stars 79 forks source link

Adding some improvements #78

Closed marcelaraujo closed 11 years ago

marcelaraujo commented 11 years ago

Adding some improvements.

Trim at classes Indent at some source codes

marcelaraujo commented 11 years ago

Do you have some explanation to tell me the reason for this? It's an equal checking for me!

YDyachenko commented 11 years ago

@marcelaraujo Because there is no div wrapper in official docs. Check "Validation states" on http://twitter.github.com/bootstrap/base-css.html#forms

marcelaraujo commented 11 years ago

You're right @Nice2MeatU but I can't understand the reason to change the php !is_null($element) for php null !== $element.

YDyachenko commented 11 years ago

@marcelaraujo oh, my fault :) posted to another tab. it's answer for https://github.com/Emagister/zend-form-decorators-bootstrap/commit/b64069be89bd9187aa907338815f61d1fb8578ed#commitcomment-2367841

marcelaraujo commented 11 years ago

No problems @Nice2MeatU ;)

theUniC commented 11 years ago

It's just because I think that the identity operator in this case It's more meaningful and slightly more faster than a is_null call.

marcelaraujo commented 11 years ago

Ok. I do