search

Email-builder / grunt-email-builder

Build Emails from HTML / CSS code in grunt
Other
94 stars 14 forks source link

New version sent! #26

Closed leetomblin closed 10 years ago

leetomblin commented 10 years ago

Sending another test of the same email build, doesn't actually seem to work?

Only shows version 1 in Litmus?

jeremypeter commented 10 years ago

I haven't been able to replicate the issue. Did you try refreshing the Litmus page and check the version dropdown menu to see if it shows up?

leetomblin commented 10 years ago

Yeah - on sending another version, the first version title changes to "No subject", although there's no version 2 in the dropdown.

I noticed when sending another version, it doesn't return any API status? (check attachment)

Using your original package (https://github.com/jeremypeter/grunt-litmus) works fine when sending other versions, however.

Thanks for taking a look :+1:

screen shot 2014-08-25 at 16 06 10

jeremypeter commented 10 years ago

Should work now in version 2.0.7 - https://github.com/yargalot/Email-Builder/commit/301f0391dd2c45c63af229afa5c560fa9ab7e3b0 @yargalot - Do you still need to push to npm manually?

leetomblin commented 10 years ago

Pulled the latest code, but still has the same issue with not sending the test, although the API status returns data now.

What's strange is if I send a test using email builder, any other versions won't show up, but if I use grunt-litmus (your original package) with the same subject... it'll show up, but miss the previous version in the dropdown - notice it makes the subject "no subject" though, I've attached a screenshot. Bizarre!

screen shot 2014-08-26 at 21 54 02

yargalot commented 10 years ago

Im on holiday in America, your gonna have to publish it manually. Sorry!

jeremypeter commented 10 years ago

@leetomblin did you do an npm install? I upgraded one of the packages. @yargalot Didn't know I had those capabilities haha! Enjoy your time!

leetomblin commented 10 years ago

Just tried a full new project, with only email-builder, on sending tests I seem to get:

Fatal error: 500 Internal Server Error

Works fine sending tests in older projects though.

jeremypeter commented 10 years ago

@leetomblin Could you pull in the newest changes I made. I refactored some code and updated a couple modules so do an npm install. Let me know if these work. They're working for me on my end now.

leetomblin commented 10 years ago

Fantastic. All working great now! Including versions.

Big thanks for this - sorry for being such a nuisance. Awesome work :+1:

yargalot commented 10 years ago

Let me know if you cant publish @jeremypeter, though I think you should be able to

jeremypeter commented 10 years ago

@leetomblin No, thank you for catching the issue.

@yargalot I just checked to see if I was an owner but it looks like you need to add me. Once you add me I should be able to publish.

yargalot commented 10 years ago

Right, so there is only one owner, and it doesnt seem to let me transfer ownership on my ipad to that corp. Gonna try and remove that master branch thing in the travis.yml file, tag it and try again. Otherwise ill go hunt down a computer.

leetomblin commented 10 years ago

Random question, is there an option in the API to enable "Allow Extra Time for Captures" ?

jeremypeter commented 10 years ago

I did speak to their support a while back and mentioned that they should add it in. For now though, there isn't a way.

yargalot commented 10 years ago

Published