search

Email-builder / grunt-email-builder

Build Emails from HTML / CSS code in grunt
Other
94 stars 14 forks source link

Referring to a css file that doesnt exist fucks the build #27

Closed yargalot closed 10 years ago

yargalot commented 10 years ago

ITT

jeremypeter commented 10 years ago

What error does it give?

yargalot commented 10 years ago

Just seems to spit out a file that doesnt inline anything

yargalot commented 10 years ago

Will skip over the rest of the linked files as well lol

jeremypeter commented 10 years ago

Alright, looks like it's an issue with the juice module. Who the hell links to a file that doesn't exist man, that's just crazy! Might have to remove the links with non-existent paths before it hits the juice method that inlines the css.

yargalot commented 10 years ago

Yehh, was a dumbass move, but made me laugh. Was a facepalm moment lol

jeremypeter commented 10 years ago

Should we support node v0.11? The build is failing.

jeremypeter commented 10 years ago

I got it working for 0.10 hahaha

yargalot commented 10 years ago

Like a boss!

jeremypeter commented 10 years ago

Fixed in 2.0.10