search

EmailThis / extension-boilerplate

⚡️ A template for building cross browser extensions for Chrome, Opera & Firefox.
https://www.emailthis.me/open-source/extension-boilerplate
MIT License
3.28k stars 370 forks source link

Fix Issue #40 #41

Open daniel-moya opened 4 years ago

daniel-moya commented 4 years ago

Bump gulp-sass from 2.3.2 to 3.0.0 😄 (This Fix Issue #40)

Error when making npm install

I solved this by changing in package.json: "gulp-sass": "^2.3.2" to "gulp-sass": "3.0.0",

https://github.com/codecombat/codecombat/issues/4430#issuecomment-348927771


npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! node-sass@3.13.1 postinstall: `node scripts/build.js`
npm ERR! Exit status 1
npm ERR!
npm ERR! Failed at the node-sass@3.13.1 postinstall script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\yrrod_000\AppData\Roaming\npm-cache\_logs\2019-10-18T09_03_25_525Z-debug.log
hhaoao commented 4 years ago

@damr67 Hello, your PR didn't completely solve the dependency problem, I found that the #36 has been perfectly solved, just did not merge into the master branch.

I find that many people don't find that the problem has been solved, and I'm here to write down how to fetch an inactive request pull, hoping to help those in need.

git clone https://github.com/EmailThis/extension-boilerplate.git
cd .\extension-boilerplate\
git fetch origin pull/36/head:genietim
git merge genietim