add cross-env for Windows build working

EmailThis / extension-boilerplate

⚡️ A template for building cross browser extensions for Chrome, Opera & Firefox.

https://www.emailthis.me/open-source/extension-boilerplate

MIT License

3.28k stars 370 forks source link

add cross-env for Windows build working #9

Closed yfdyh000 closed 7 years ago

cmolina commented 7 years ago

Nice work! @yfdyh000 maybe you could consider editing the README with instructions to install global packages gulp and cross-env.

yfdyh000 commented 7 years ago

I'm not familiar with Node.js / npm, don't understand such benefits. If you wish, I can remove the change for devDependencies. If it can be done automatically, why should write a step to manually install it to the global?

In addition, I just wrote my installed version, did not write * or something else, not sure it is the best practice.

cmolina commented 7 years ago

You are right @yfdyh000 , I didn't notice you added cross-env as a dependency, I though it was a global package, my bad.

siamkreative commented 7 years ago

Can't wait for this to be merged :)