Closed rvanlaak closed 8 years ago
@Nyholm would it be wise to document psr/cache-implementation
here too, instead of suggesting cache/adapter-bundle
?
https://github.com/asm89/twig-cache-extension/pull/32 is merged now so this one also can get merged.
I think you should mention that you have to install a package providing psr/cache-implementation
. The cache/adapter-bundle makes it easier to configure that package and add it as a Symfony service.
ping @EmanueleMinotto the PR with the adapter is merged, no release was tagged yet but this PR can be merged after that.
thanks @rvanlaak, I'm waiting for a tag in the asm89/twig-cache-extension repo, after that I'll merge your PR :)
Great! :+1: FYI: I've did some textual changes based on @Nyholm's feedback to clarify the relationship with the PSR-6, you think it is clear now too?
@EmanueleMinotto I've added classes to the README, still waiting on the tag to be released :-1:
@EmanueleMinotto v1.3.0
was tagged! :tada:
Fainally merged, @rvanlaak thank you very much for your effort! :) What about https://github.com/EmanueleMinotto/TwigCacheBundle/issues/12 now?
You can use the new adapter already, just do a composer update
.
https://github.com/asm89/twig-cache-extension/pull/32 will introduce a new adapter that allows you to configure any cache pool that implements the
CacheItemPoolInterface
. This will introduce a lot of adapters to the Twig caching extension: http://php-cache.readthedocs.io/en/latest/This documentation PR can be merged once the other PR with the adapter is merged and
1.3.0
of the extension was released.