EmanueleMinotto / TwigCacheBundle

Symfony Bundle for asm89/twig-cache-extension
59 stars 13 forks source link

Document PSR-6 cache adapters #14

Closed rvanlaak closed 8 years ago

rvanlaak commented 8 years ago

https://github.com/asm89/twig-cache-extension/pull/32 will introduce a new adapter that allows you to configure any cache pool that implements the CacheItemPoolInterface. This will introduce a lot of adapters to the Twig caching extension: http://php-cache.readthedocs.io/en/latest/

This documentation PR can be merged once the other PR with the adapter is merged and 1.3.0 of the extension was released.

rvanlaak commented 8 years ago

@Nyholm would it be wise to document psr/cache-implementation here too, instead of suggesting cache/adapter-bundle?

https://github.com/asm89/twig-cache-extension/pull/32 is merged now so this one also can get merged.

Nyholm commented 8 years ago

I think you should mention that you have to install a package providing psr/cache-implementation. The cache/adapter-bundle makes it easier to configure that package and add it as a Symfony service.

rvanlaak commented 8 years ago

ping @EmanueleMinotto the PR with the adapter is merged, no release was tagged yet but this PR can be merged after that.

EmanueleMinotto commented 8 years ago

thanks @rvanlaak, I'm waiting for a tag in the asm89/twig-cache-extension repo, after that I'll merge your PR :)

rvanlaak commented 8 years ago

Great! :+1: FYI: I've did some textual changes based on @Nyholm's feedback to clarify the relationship with the PSR-6, you think it is clear now too?

rvanlaak commented 8 years ago

@EmanueleMinotto I've added classes to the README, still waiting on the tag to be released :-1:

rvanlaak commented 8 years ago

@EmanueleMinotto v1.3.0 was tagged! :tada:

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 66.667% when pulling 08cb5d3e576893feffb42eb0ad806fef865eef1f on rvanlaak:psr6 into 37aa9e138d730f2089e2d57703e2c5b35ecd8b96 on EmanueleMinotto:master.

EmanueleMinotto commented 8 years ago

Fainally merged, @rvanlaak thank you very much for your effort! :) What about https://github.com/EmanueleMinotto/TwigCacheBundle/issues/12 now?

rvanlaak commented 8 years ago

You can use the new adapter already, just do a composer update.