fix deprecation message.

EmanueleMinotto / TwigCacheBundle

Symfony Bundle for asm89/twig-cache-extension

59 stars 13 forks source link

fix deprecation message. #16

Closed DenysMedvid closed 7 years ago

DenysMedvid commented 7 years ago

Referencing the ... extension by its name (defined by getName()) is deprecated since 1.26 and will be removed in Twig 2.0. Use the Fully Qualified Extension Class Name instead

We can not use getName method. Also, added registration of parent Extension.

This PR linked to https://github.com/asm89/twig-cache-extension/pull/37

coveralls commented 7 years ago

Coverage increased (+0.5%) to 67.123% when pulling cdc5400ef4e69d756d1f6e2a55e15f5faa2b477c on DenisMedved:master into fc302475590a26579c10c2f00e411f64ac9d9945 on EmanueleMinotto:master.

sc0rp10 commented 7 years ago

tjveldhuizen commented 7 years ago

DenysMedvid commented 7 years ago

PR https://github.com/asm89/twig-cache-extension/pull/37 has merged.

EmanueleMinotto commented 7 years ago

Sorry @DenisMedved but I don't get wat's changed here, could you add at least a test, please?

DenysMedvid commented 7 years ago

After all updates i cannot reproduce message again. So, i think this PR should be closed .

DenysMedvid commented 7 years ago

Looks like this PR can fix #17

coveralls commented 7 years ago

Coverage increased (+0.5%) to 67.123% when pulling cdc5400ef4e69d756d1f6e2a55e15f5faa2b477c on DenisMedved:master into fc302475590a26579c10c2f00e411f64ac9d9945 on EmanueleMinotto:master.

keesschepers commented 7 years ago

For us it also fixed #17 so I would opt to merge it if possible.

nuffer commented 7 years ago

mullerch commented 7 years ago

ahilles107 commented 7 years ago

👍

multifinger commented 7 years ago

Why so long (((

multifinger commented 7 years ago

To use provided FIX in composer I've forked DenisMedved repo and tagged it with bugfix branch So you can use it like this in composer.json:

"repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/multifinger/TwigCacheBundle"
        }
]

and

"require": {
    "emanueleminotto/twig-cache-bundle": "dev-bugfix"
}

Additionaly you may need to generate git OAuth token to prevent API rate limit

DenysMedvid commented 7 years ago

As temporary solution, you can attach fork repository

repositories": [
        {
            "type": "vcs",
            "url": "git@github.com:DenisMedved/twig-cache-extension.git"
        },
        {
            "type": "vcs",
            "url": "git@github.com:DenisMedved/TwigCacheBundle.git"
        }
    ],

    "require": {
          ...
        "exercise/htmlpurifier-bundle": "dev-master",
        "emanueleminotto/twig-cache-bundle": "dev-custom",
       ...
    },

EmanueleMinotto commented 7 years ago

Sorry guys, tbh I don't have time to maintain this bundle, I'll try to take a look this evening but I'm not sure if I'll have time. Anyway if someone is interested in maintaining it, just write me and I'll add you. :)

EmanueleMinotto commented 7 years ago

Time to merge 👍 I'm really sorry for the delay and thank you for the PR :)