search

EmanueleMinotto / TwigCacheBundle

Symfony Bundle for asm89/twig-cache-extension
59 stars 13 forks source link

Version 1.3.1 TwigCacheExtension not compatible #17

Closed Gemineye closed 7 years ago

Gemineye commented 7 years ago

Hi,

I think this change breaks your logic in the dependency injection:

https://github.com/asm89/twig-cache-extension/commit/0ffaf529de8662eb0bccae00c9075871ac256839

You also need to check the Twig version I think.

Regards Harald

EmanueleMinotto commented 7 years ago

Thank you, I'll check asap

rvanlaak commented 7 years ago

Same here, the Twig extension isn't enabled anymore on build. Probably not related, but we also updated to Twig 1.30 at the same time. Also see https://github.com/asm89/twig-cache-extension/issues/40

DenysMedvid commented 7 years ago

I think, there is solution in PR #16

krafas commented 7 years ago

@EmanueleMinotto did you check? :)

Gemineye commented 7 years ago

Any news?

buffcode commented 7 years ago

I fixed a similar issue using a custom service, see here for reference: https://github.com/asm89/twig-cache-extension/pull/46#issuecomment-276946354

EmanueleMinotto commented 7 years ago

This is solved in v1.0.4