Module Install Error does not appear to be firing OnInstallError

peardox commented 2 years ago

Noticed on old Android Tablet 32 with 3GB RAM

I was not getting any notifications at all so wrapped everything in try ... except and see I'm getting a PyModuleCheckInstallError but the event never fires

peardox commented 2 years ago

Further investigation

Tracked issue down to happening here

https://github.com/Embarcadero/Lightweight-Python-Wrappers/blob/main/src/PyPackage.pas#L364

At some point during this call it raises an exception which is why the OnError isn't called (it never gets that far)

I have only seen this happen on Android - tested with https://github.com/peardox/P4D-Tests - project dir "01 - Hello CPU FMX"

It works fine on other platforms - as Memory is a possible issue the project has largeHeap enabled

lmbelo commented 2 years ago

You're trying it on Android, but you're not placing the Python interpreter and executable in the App lib folder. Try that new deployment feature I've last introduced and it will work, or you can deploy it by yourself.

peardox commented 2 years ago

Oh, rats - sandbox...

One of these then...

https://docwiki.embarcadero.com/RADStudio/Alexandria/en/Standard_RTL_Path_Functions_across_the_Supported_Target_Platforms

For proper stuff on Windows I set this to System.IOUtils.TPath.GetHomePath + '/appname'

Possibly in Android it wants...

TPath.GetLibraryPath

peardox commented 2 years ago

At least I get some response with EnvironmentPath set to GetPathHome

lmbelo commented 2 years ago

Haa... you've almost got it.

peardox commented 2 years ago

Sadly the error is from importing PSUtil (it's not big)

lmbelo commented 2 years ago

Sadly the error is from importing PSUtil (it's not big)

Ah, an OpenGL memory lack :/

peardox commented 2 years ago

I'll try it on my TV (via NVIDIA Shield TV - it's got a small GPU in it...)

lmbelo commented 2 years ago

I'll try it on my TV (via NVIDIA Shield TV - it's got a small GPU in it...)

Isn't it for streaming only?

Ah, understood. You've installed it on your NVIDIA Shield TV.

peardox commented 2 years ago

Finally worked out how to get ChromeBook installs of APKs (Delphi will say it can't - adb install ... says otherwise)

My test app (the FMX version) - https://github.com/peardox/P4D-Tests - is now more functional but still won't load any libs on Android. Note that Unit1.pas has some $DEFINES at the top you can use to switch modules in and out for testing

Video (sorry about the audio - had a ChomeBook howto in background...)

https://user-images.githubusercontent.com/1549219/184138653-93381c25-c3e6-474f-b30b-29dda73d4f9b.mp4

Note that although I recorded this from the ChromeBook (easiest to record) this is what happens on EVERY device I've tried so far (Huawei Phone, Samsung Tablet, NVIDIA Shield TV and the ChromeBook - I've got more as well [Amazon rubbish devices]...)

This error is happening in the same routine I reported yesterday.

I could always test on a high-end Droid but then I'll have to work out how to use AWS's Device Farm (much simpler locally) - also, I'd expect at least the smaller packages to install ok - but nothing does...

lmbelo commented 2 years ago

I will get it working for you.

lmbelo commented 2 years ago

BTW, are you trying to install Torch for Android? The default Torch version is not available for Android.

peardox commented 2 years ago

That was just the first in order in the video, before it was PSUtils

Torch should install OK, it'll just come in without CUDA - at least this is what happens on arm64 SBCs like the NVIDIA Jetson - like this...

simon@nano:~$ pip list
Package            Version
------------------ ---------
certifi            2022.6.15
charset-normalizer 2.1.0
idna               3.3
numpy              1.23.0
Pillow             9.2.0
pip                22.1.2
psutil             5.9.1
requests           2.28.1
scipy              1.8.1
setuptools         58.1.0
torch              1.12.0
torchaudio         0.12.0
torchvision        0.13.0
typing_extensions  4.3.0
urllib3            1.26.9

[notice] A new release of pip available: 22.1.2 -> 22.2.2
[notice] To update, run: pip install --upgrade pip
simon@nano:~$ uname -a
Linux nano 4.9.253-tegra #1 SMP PREEMPT Mon Jul 26 12:13:06 PDT 2021 aarch64 aarch64 aarch64 GNU/Linux

Should actually be able to get the CUDA extensions on that thing

lmbelo commented 2 years ago

Torch is an extension module. It must be compiled with Android NDK toolchain to work on Android. They don't have it available on PYPI, you need to build it yourself from source. There's a step-by-step guide on their's official website.

peardox commented 2 years ago

BTW - Has this bunch of packages actually been tested on physical Android? I notice that the Torch demo @jimmckeeth shows on the YouTube vid is Client Server (so the Android app could be not running Python in the first place - can't really tell, it uses non CE components - DB stuff)

lmbelo commented 2 years ago

That sample is for showcase only purpose, and it's totally useless on real world. There's no Python running in the Android side. We collect and send images to the datasnap server. We can also order training and live recognition, but it all runs in the server side.

peardox commented 2 years ago

Torch is an extension module. It must be compiled with Android NDK toolchain to work on Android. They don't have it available on PYPI, you need to build it yourself from source. There's a step-by-step guide on their's official website.

I'll check that out but disabling Torch in HelloCPUFMX so it just tries PSUtil also acts the same

I hate it when things that should work don't :(

lmbelo commented 2 years ago

I was wondering if it worth to spend some time to create the Torch installer file for Setuptools for Android.

lmbelo commented 2 years ago

Torch is an extension module. It must be compiled with Android NDK toolchain to work on Android. They don't have it available on PYPI, you need to build it yourself from source. There's a step-by-step guide on their's official website.

I'll check that out but disabling Torch in HelloCPUFMX so it just tries PSUtil also acts the same

I hate it when things that should work don't :(

PSUtil has a source distribution on PYPI, so it works :)

lmbelo commented 2 years ago

Torch is an extension module. It must be compiled with Android NDK toolchain to work on Android. They don't have it available on PYPI, you need to build it yourself from source. There's a step-by-step guide on their's official website.

I'll check that out but disabling Torch in HelloCPUFMX so it just tries PSUtil also acts the same

I hate it when things that should work don't :(

It works, you only need to find its way, though.

peardox commented 2 years ago

I just noticed that PSUtil and Torch had AutoInstall + AutoImport checked (the default) so turned those off as the test installs and imports them itself. No difference though.

AutoInstall + AutoImport - seems to me they should default to false

peardox commented 2 years ago

Just tested on Phone - illuminating error messages... msvcrt

Errm - it's android - why is it trying to import msvcrt?

msvcrt

And it can't find it's lib - possibly x64 got installed for some reason? That would explain it looking for mscvrt and not finding the so

OTOH my ChromeBook would probably work with the wrong stuff as it's Intel in the first place (fixing may stop chromebook working I guess - no biggie for now)

peardox commented 2 years ago

Nope - lib is there on Android...

lmbelo commented 2 years ago

You need to place the Python shared library and executable in the same folder as your app. You MUST deploy it to "library\lib\arm64-v8a" if you're doing it 64-bit. Use that Python project setup, as I said before, it is very straightforward.

Screen Shot 2022-08-11 at 16 55 30