EmbarkStudios / cargo-deny

❌ Cargo plugin for linting your dependencies 🦀
http://embark.rs
Apache License 2.0
1.62k stars 80 forks source link

Disabling logging causes summary to be incorrect #652

Closed matthiasbeyer closed 2 months ago

matthiasbeyer commented 2 months ago

Describe the bug

$ cargo deny -L off  --format json check license
{"fields":{"licenses":{"errors":0,"helps":0,"notes":0,"warnings":0}},"type":"summary"}

And:

$ cargo deny --format json check license
# some more output
{"fields":{"licenses":{"errors":1,"helps":0,"notes":0,"warnings":0}},"type":"summary"}

To reproduce

cargo new --bin foo && cd foo && cargo deny -L off --format json check license && cargo deny --format json check license

cargo-deny version

cargo-deny 0.14.21

What OS were you running cargo-deny on?

Linux

Additional context

No response

Jake-Shadle commented 2 months ago

~I guess I don't understand what your desired behavior is? You want to disable logging, except for errors? Why can you not use -L error?~

Oh nvm I see what you are saying, disabling logging means the final summary loses all information.

matthiasbeyer commented 2 months ago

Awesome, thanks!