Now with #17 we have 3 different client/server implementations in minidumper for each platform, but now that I've proved that Unix domain sockets can work on all of the (current) target platforms, it makes sense to consolidate them down to a single client and server implementation, with inline platform specifics instead of a bunch of duplicated code. The only big difference between them is the handling of the platform specific crash context, and in the case of linux, the use of abstract names versus filepaths, and the user of ancillary data for retrieving the client PID.
Jake-Shadle
commented
2 years ago
Now with #17 we have 3 different client/server implementations in minidumper for each platform, but now that I've proved that Unix domain sockets can work on all of the (current) target platforms, it makes sense to consolidate them down to a single client and server implementation, with inline platform specifics instead of a bunch of duplicated code. The only big difference between them is the handling of the platform specific crash context, and in the case of linux, the use of abstract names versus filepaths, and the user of ancillary data for retrieving the client PID.