EmbarkStudios / crash-handling

Collection of crates to deal with crashes
Apache License 2.0
138 stars 13 forks source link

Add Android support for the i686 and x86-64 targets to the crash-context crate #76

Closed gabrielesvelto closed 1 year ago

gabrielesvelto commented 1 year ago

Checklist

Description of Changes

This PR adds Android support for the i686 and x86-64 targets. This is largely used within emulators for testing. Note that I didn't add the architectures as supported in the top-level README.md file because I am still in the process of stabilizing Android support in the minidump-writer crate. Once that's done adding support within the crate should be trivial.

Related Issues

N/A

gabrielesvelto commented 1 year ago

The failure on macOS appears to be an issue with minidump-writer that has been potentially surfaced by new Rust versions. We're casting a pointer with a 4-bytes alignment into one that requires 8-bytes alignment. I'll file an issue and fix it.

gabrielesvelto commented 1 year ago

I prepared a PR to fix the failure here (here it is). @Jake-Shadle do you have some time to review this as well as https://github.com/rust-minidump/minidump-writer/pull/81 ?