Improper validation of image asset keys

EmbarkStudios / discord-sdk

An open implementation of the Discord Game SDK in Rust

Apache License 2.0

150 stars 10 forks source link

Improper validation of image asset keys #25

Closed winrg closed 1 year ago

winrg commented 1 year ago

Describe the bug discord_sdk::activity::Assets::{large_image, small_image} don't properly validate what is passed in to them. The 32-char limit applies to keys, but not to proxied URLs, which have no such length limit.

Expected behavior For it to not incorrectly discard data.

winrg commented 1 year ago

My mistake, this is fixed properly now in #30.