search

EmbarkStudios / k8s-buildkite-plugin

Run any buildkite build step as a Kubernetes Job
https://embark.dev
Apache License 2.0
49 stars 19 forks source link

Strip quotes from stepEnv #30

Closed keith closed 3 years ago

keith commented 3 years ago

Fixes https://github.com/EmbarkStudios/k8s-buildkite-plugin/issues/29

keith commented 3 years ago

If you had an escaped double quote as the last character of your string this would break that I guess 🙃

iffyio commented 3 years ago

Thanks for creating a PR for this :raised_hands: I'll make some time to take a look at it soon!

keith commented 3 years ago

thanks!