search

EmbarkStudios / k8s-buildkite-plugin

Run any buildkite build step as a Kubernetes Job
https://embark.dev
Apache License 2.0
49 stars 19 forks source link

artifact-path implementation #69

Open clbx opened 1 year ago

clbx commented 1 year ago

Is your feature request related to a problem? Please describe. The artifact-path argument in buildkite does not work since it runs on the agent, not the job.

Describe the solution you'd like An argument for the plugin that replicates the features of the buildkite argument.

Additional context Ive thought about when this could be done, the command could be appended to the end of any commands run in the pod, or it may be possible in a post-command step, but I'm not sure when this could be done.

I plan on opening a PR for this in the future when I get time, but I don't have the capacity right now.

tgolsson commented 1 year ago

The plugin runs in the container aswell but currently just fizzles; might be a good place to hook there? Should have access to all the configuration iirc.

https://github.com/EmbarkStudios/k8s-buildkite-plugin/blob/720b4b79f2a89d47e4efd268f4a41b0d950f178b/hooks/pre-exit#L9-L12

clbx commented 1 year ago

Yeah I think that would be a good place to put it.