Improve `Array`, `List`, and `Map` methods - Githubissues

EmbarkStudios / mirror-mirror

🪞 Powerful reflection library for Rust

Apache License 2.0

79 stars 2 forks source link

Improve `Array`, `List`, and `Map` methods #136

Closed davidpdrsn closed 6 months ago

davidpdrsn commented 6 months ago

Checklist

[x] I have read the Contributor Guide
[x] I have read and agree to the Code of Conduct
[x] I have added a description of my changes and why I'd like them included in the section below

Description of Changes

Pass over methods on Array, List, and Map that makes things more explicit and adds a few new useful methods:

Add Array::swap
Add List::try_insert
List::push renamed to List::try_push and now returns a result indicating that FromReflect::from_reflect failed
Map::insert renamed to Map::try_insert and also returns result
Map::remove renamed to Map::try_remove and also returns result

Also deduplicated the Map impls.

Related Issues

Fixes https://github.com/EmbarkStudios/mirror-mirror/issues/132